RUN-41 Serde deprecated #318
Conversation
AHaliq
added
[Size] Large
[Type] Maintenance
AHaliq
force-pushed
the
serde_deprecated
branch
7 times, most recently
from
e8c4d78 to
323233a
Compare
AHaliq
force-pushed
the
serde_deprecated
branch
from
323233a to
490efba
Compare
AHaliq
force-pushed
the
serde_deprecated
branch
3 times, most recently
from
c8544c7 to
69e9ac5
Compare
AHaliq
force-pushed
the
serde_deprecated
branch
from
a6e3cc5 to
91d4d14
Compare
AHaliq
force-pushed
the
serde_deprecated
branch
from
91d4d14 to
5209c05
Compare
AHaliq
force-pushed
the
serde_deprecated
branch
from
5209c05 to
b1ba482
Compare
| - `internal::timestamp_millis` | ||
| - `internal::account_amounts` | ||
| - `internal::duration_millis` | ||
| - `types::smart_contracts::contract_trace_Via_events` | ||
| - `types::summary_helper` |
There was a problem hiding this comment.
Notice that none of these are public, so we don't need to mention them
| - `internal::duration_millis` | ||
| - `types::smart_contracts::contract_trace_Via_events` | ||
| - `types::summary_helper` | ||
| - serde relevant `derive`s and `impl`s guarded by flag |
There was a problem hiding this comment.
I think the formulation you used in the readme is more precise. "The flag serde_deprecated now guards serde::Serialize and serde::Deserialize implementations on the following types. The implementations will eventually be removed".
Derive is just an implementation detail of how the traits are implemented and is not really relevant to mention.
| - `types::smart_contracts::instance_parser::InstanceInfoHelper` | ||
| - `types::smart_contracts::ContractContext` | ||
| - `types::smart_contracts::InvokeContractResult` | ||
| - `examples::update-validator-score-param::main` test to print results when flag disabled; without serde |
There was a problem hiding this comment.
I think that the change to examples is not really notable enough to mention (but not a big deal, we just need some filter of notability in what we mention)
| - `types::queries::PendingUpdate` | ||
| - `types::queries::PendingUpdateEffect` | ||
| - `types::smart_contracts::InstanceInfo` | ||
| - `types::smart_contracts::instance_parser::InstanceInfoHelper` |
There was a problem hiding this comment.
InstanceInfoHelper is also not public?
| - `types::StakePendingChange` | ||
| - `types::RewardsOverview` | ||
| - `types::CommonRewardData` | ||
| - `types::reward_overview::RewardsDataRaw` |
allanbrondum
left a comment
allanbrondum
left a comment
There was a problem hiding this comment.
Just have a few comments for making changelog more precise
Purpose
Guard serde relevant constructs behind a feature flag eventually to be turned off by default
Changes
cd serde-refactor && cargo run -- ../concordium-rust-sdk/src --dry-runto see candidates insrcsrc/**andexamples/**Checklist
hard-to-understand areas.
CLA acceptance
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.